Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add govuk_web_banner gem #3456

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Add govuk_web_banner gem #3456

merged 1 commit into from
Dec 3, 2024

Conversation

KludgeKML
Copy link
Contributor

  • partial inserted before header yield - in most cases there is no header. In HMRC manuals there is, and it looks like it would split up the content oddly to have the banner below that.

https://trello.com/c/aYXKcrCo/375-create-govukwebbanner-gem-with-support-for-recruitment-banners

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

- partial inserted before header yield - in most cases there is no header. In HMRC manuals there is, and it looks like it would split up the content oddly to have the banner below that.
@KludgeKML KludgeKML requested a review from leenagupte December 2, 2024 15:36
@govuk-ci govuk-ci temporarily deployed to government-frontend-pr-3456 December 2, 2024 15:37 Inactive
@KludgeKML KludgeKML requested a review from hannako December 2, 2024 15:45
@KludgeKML KludgeKML merged commit 4ff56c2 into main Dec 3, 2024
12 checks passed
@KludgeKML KludgeKML deleted the add-govuk_web_banner-gem branch December 3, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants